[asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

[Olle E. Johansson]

25 okt 2013 kl. 00:50 skrev "Paul Belanger" <reviewboard at asterisk.org>:

> My only comment is about the naming conventions, we should try and keep AMI events in sync.  Right now we have FooBegin / FooEnd, and FooStart / FooStop, and Foo / FooComplete.  I'd like us see about pick one format and sticking with it when possible.
> 
> I believe Begin / End has been the most recent addition, do we want to default to that?
I like better the design we decided upon in AMI 1.1 - to have ONE event name and a status field that tells the app if it's start/stop or being/end or something else. We have tried to stop FooBegin/FooEnd and similar constructs for a long time.

Like 

Event: foo
Status: begin

/O
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131025/bb3ddea1/attachment.html>