[asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

[Jason Parker]

In the future, can you please respond through reviewboard, so that email
filters can tag these properly?


On Thu, Oct 24, 2013 at 6:11 PM, Olle E. Johansson <oej at edvina.net> wrote:

>
> 25 okt 2013 kl. 00:50 skrev "Paul Belanger" <reviewboard at asterisk.org>:
>
> My only comment is about the naming conventions, we should try and keep AMI events in sync.  Right now we have FooBegin / FooEnd, and FooStart / FooStop, and Foo / FooComplete.  I'd like us see about pick one format and sticking with it when possible.
>
> I believe Begin / End has been the most recent addition, do we want to default to that?
>
> I like better the design we decided upon in AMI 1.1 - to have ONE event
> name and a status field that tells the app if it's start/stop or being/end
> or something else. We have tried to stop FooBegin/FooEnd and similar
> constructs for a long time.
>
> Like
>
> Event: foo
> Status: begin
>
> /O
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131025/52665239/attachment-0001.html>