[asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2959/#review9992
-----------------------------------------------------------


My only comment is about the naming conventions, we should try and keep AMI events in sync.  Right now we have FooBegin / FooEnd, and FooStart / FooStop, and Foo / FooComplete.  I'd like us see about pick one format and sticking with it when possible.

I believe Begin / End has been the most recent addition, do we want to default to that?

- Paul Belanger


On Oct. 24, 2013, 5:43 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2959/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 5:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-22609
>     https://issues.asterisk.org/jira/browse/ASTERISK-22609
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Created the following AMI commands and corresponding events for res_pjsip:
> 
> PJSIPShowEndpoints - Provides a listing of all pjsip endpoints and a few select attributes on each.
>   Events:
>     EndpointList - for each endpoint a few attributes
>     EndpointlistComplete - after all endpoints have been listed
> 
> PJSIPShowEndpoint - Provides a detail list of attributes for a specified endpoint
>   Events:
>     EndpointDetail - attributes on an endpoint
>     AorDetail - raised for each AOR on an endpoint
>     AuthDetail - raised for each associated inbound and outbound auth
>     TransportDetail - transport attributes
>     IdentifyDetail - attributes for the identify object associated with the endpoint
>     EndpointDetailComplete - last event raised after all detail events
> 
> PJSIPShowRegistrationsInbound - Provides a detail listing of all inbound registrations
>   Events:
>     InboundRegistrationDetail - inbound registration attributes for each registration
>     InboundRegistrationDetailComplete - raised after all detail records have been listed
> 
> PJSIPShowRegistrationsOutbound  - Provides a detail listing of all outbound registrations
>   Events:
>     OutboundRegistrationDetail - outbound registration attributes for each registration
>     OutboundRegistrationDetailComplete - raised after all detail records have been listed
> 
> PJSIPShowSubscriptions - A detail listing of all subscriptions and their attributes
>   Events:
>     SubscriptionDetail - on each subscription detailed attributes
>     SubscriptionDetailComplete - raised after all detail records have been listed
> 
> 
> Diffs
> -----
> 
>   branches/12/include/asterisk/acl.h 401659 
>   branches/12/include/asterisk/manager.h 401659 
>   branches/12/include/asterisk/res_pjsip.h 401659 
>   branches/12/include/asterisk/res_pjsip_pubsub.h 401659 
>   branches/12/include/asterisk/sorcery.h 401659 
>   branches/12/include/asterisk/strings.h 401659 
>   branches/12/main/acl.c 401659 
>   branches/12/main/manager.c 401659 
>   branches/12/main/sorcery.c 401659 
>   branches/12/main/utils.c 401659 
>   branches/12/res/res_pjsip.c 401659 
>   branches/12/res/res_pjsip.exports.in 401659 
>   branches/12/res/res_pjsip/config_auth.c 401659 
>   branches/12/res/res_pjsip/config_transport.c 401659 
>   branches/12/res/res_pjsip/include/res_pjsip_private.h 401659 
>   branches/12/res/res_pjsip/location.c 401659 
>   branches/12/res/res_pjsip/pjsip_configuration.c 401659 
>   branches/12/res/res_pjsip_endpoint_identifier_ip.c 401659 
>   branches/12/res/res_pjsip_exten_state.c 401659 
>   branches/12/res/res_pjsip_mwi.c 401659 
>   branches/12/res/res_pjsip_outbound_registration.c 401659 
>   branches/12/res/res_pjsip_pubsub.c 401659 
>   branches/12/res/res_pjsip_registrar.c 401659 
> 
> Diff: https://reviewboard.asterisk.org/r/2959/diff/
> 
> 
> Testing
> -------
> 
> Ran a few manual tests over AMI and observed the output to make sure things look correct.  Also wrote some testsuite tests: https://reviewboard.asterisk.org/r/2958/
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131024/cfc4d3ea/attachment-0001.html>