[asterisk-dev] [Code Review] 2906: Use POST / DELETE to handle toggle of hold / unhold and mohstart / mohstop

svnbot reviewboard at asterisk.org
Tue Oct 15 10:28:50 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2906/
-----------------------------------------------------------

(Updated Oct. 15, 2013, 10:28 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 400999


Repository: Asterisk


Description
-------

While spending my time with ARI over the last few days, I've been seeing some room for improvements. For example, today we explicitly return a user to pass toggle actions via the URL.  I believe HTTP has a built-in function that will help make this easier.  So, I am proposing we use the POST / DELETE functions from HTTP to handle some toggle events.

This change updates how we toggle a hold and moh, to be much cleaner IMO for HTTP.


Diffs
-----

  trunk/res/res_ari_channels.c 400880 
  trunk/rest-api/api-docs/channels.json 400880 

Diff: https://reviewboard.asterisk.org/r/2906/diff/


Testing
-------

local development box


Thanks,

Paul Belanger

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131015/92497037/attachment.html>


More information about the asterisk-dev mailing list