[asterisk-dev] [Code Review] 2906: Use POST / DELETE to handle toggle of hold / unhold and mohstart / mohstop

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2906/#review9911
-----------------------------------------------------------

Ship it!


I was going to do this myself.

- David Lee


On Oct. 14, 2013, 7 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2906/
> -----------------------------------------------------------
> 
> (Updated Oct. 14, 2013, 7 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While spending my time with ARI over the last few days, I've been seeing some room for improvements. For example, today we explicitly return a user to pass toggle actions via the URL.  I believe HTTP has a built-in function that will help make this easier.  So, I am proposing we use the POST / DELETE functions from HTTP to handle some toggle events.
> 
> This change updates how we toggle a hold and moh, to be much cleaner IMO for HTTP.
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_ari_channels.c 400880 
>   trunk/rest-api/api-docs/channels.json 400880 
> 
> Diff: https://reviewboard.asterisk.org/r/2906/diff/
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul Belanger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131015/a45b878c/attachment.html>