[asterisk-dev] [Code Review] 2906: Use POST / DELETE to handle toggle of hold / unhold and mohstart / mohstop

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2906/#review9909
-----------------------------------------------------------


Dan Jenkins wrote:

{quote}
David and I spoke about this at Astricon, seems like a good idea to me; if people aren't closed to making such a "big" change to the interface.
{quote}

While I don't want to turn the next few months into a "let's redo everything" - that's why we have code reviews and a process in the first place - I'm all for using the time 12 is in beta as an opportunity to get the API right before it is officially released. Without commenting on whether or not this change is the right thing to do, I'm good with changes like this before 12 is released.

- Matt Jordan


On Oct. 15, 2013, midnight, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2906/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, midnight)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> While spending my time with ARI over the last few days, I've been seeing some room for improvements. For example, today we explicitly return a user to pass toggle actions via the URL.  I believe HTTP has a built-in function that will help make this easier.  So, I am proposing we use the POST / DELETE functions from HTTP to handle some toggle events.
> 
> This change updates how we toggle a hold and moh, to be much cleaner IMO for HTTP.
> 
> 
> Diffs
> -----
> 
>   trunk/res/res_ari_channels.c 400880 
>   trunk/rest-api/api-docs/channels.json 400880 
> 
> Diff: https://reviewboard.asterisk.org/r/2906/diff/
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul Belanger
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20131015/98b4d146/attachment-0001.html>