[asterisk-dev] [Code Review] 2564: app_meetme: manager events to stasis

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2564/
-----------------------------------------------------------

(Updated May 30, 2013, 10:05 p.m.)


Review request for Asterisk Developers, kmoore and Matt Jordan.


Changes
-------

Address Kinsey's findings, make some other minor changes to variable names and such.


Bugs: ASTERISK-21467
    https://issues.asterisk.org/jira/browse/ASTERISK-21467


Repository: Asterisk


Description
-------

Refactor the events for app_meetme to go through stasis similar to confbridge.

Since there aren't any bridges involved, everything goes through channel topics (which is a little odd since some of the events don't actually involve channels, in which case they go out over the all channel topic, but since only meetme responds to the meetme message type anyway, it doesn't really matter).


Diffs (updated)
-----

  /trunk/apps/app_meetme.c 390154 
  /trunk/apps/confbridge/confbridge_manager.c 390154 
  /trunk/include/asterisk/manager.h 390154 
  /trunk/main/manager.c 390154 

Diff: https://reviewboard.asterisk.org/r/2564/diff/


Testing
-------

Checked that each event type gets properly relayed over AMI with all of the expected fields.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130530/2c3d5d43/attachment.htm>