[asterisk-dev] [Code Review] 2564: app_meetme: manager events to stasis

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2564/#review8723
-----------------------------------------------------------



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/2564/#comment17087>

    Is it possible to include all elements from MeetmeJoin?  If so, this should be applied to the other new documentation as well.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/2564/#comment17089>

    The definition, init, and cleanup for this message type should use the STASIS_MESSAGE_TYPE_* macros.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/2564/#comment17090>

    Using types like this in the json prevents the message router from being effective. Each variant of the "type" field should have its own message type and the type field should go away.


- opticron


On May 23, 2013, 2:09 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2564/
> -----------------------------------------------------------
> 
> (Updated May 23, 2013, 2:09 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21467
>     https://issues.asterisk.org/jira/browse/ASTERISK-21467
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Refactor the events for app_meetme to go through stasis similar to confbridge.
> 
> Since there aren't any bridges involved, everything goes through channel topics (which is a little odd since some of the events don't actually involve channels, in which case they go out over the all channel topic, but since only meetme responds to the meetme message type anyway, it doesn't really matter).
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 389532 
>   /trunk/apps/confbridge/confbridge_manager.c 389532 
>   /trunk/include/asterisk/manager.h 389532 
>   /trunk/main/manager.c 389532 
> 
> Diff: https://reviewboard.asterisk.org/r/2564/diff/
> 
> 
> Testing
> -------
> 
> Checked that each event type gets properly relayed over AMI with all of the expected fields.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130529/daeb4583/attachment.htm>