[asterisk-dev] [Code Review] 2564: app_meetme: manager events to stasis

[Jason Parker]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2564/#review8740
-----------------------------------------------------------



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/2564/#comment17115>

    This doesn't exist.  See below.



/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/2564/#comment17116>

    Why not just use the extras blob, and pass in the status when it's needed?


- Jason Parker


On May 30, 2013, 10:05 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2564/
> -----------------------------------------------------------
> 
> (Updated May 30, 2013, 10:05 p.m.)
> 
> 
> Review request for Asterisk Developers, kmoore and Matt Jordan.
> 
> 
> Bugs: ASTERISK-21467
>     https://issues.asterisk.org/jira/browse/ASTERISK-21467
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Refactor the events for app_meetme to go through stasis similar to confbridge.
> 
> Since there aren't any bridges involved, everything goes through channel topics (which is a little odd since some of the events don't actually involve channels, in which case they go out over the all channel topic, but since only meetme responds to the meetme message type anyway, it doesn't really matter).
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 390154 
>   /trunk/apps/confbridge/confbridge_manager.c 390154 
>   /trunk/include/asterisk/manager.h 390154 
>   /trunk/main/manager.c 390154 
> 
> Diff: https://reviewboard.asterisk.org/r/2564/diff/
> 
> 
> Testing
> -------
> 
> Checked that each event type gets properly relayed over AMI with all of the expected fields.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130531/5b76a43b/attachment.htm>