[asterisk-dev] [Code Review] 2544: Refactor CEL channel events on top of Stasis-Core

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2544/
-----------------------------------------------------------

(Updated May 21, 2013, 5:03 p.m.)


Review request for Asterisk Developers.


Changes
-------

Address comments and apply sadnessectomy. This pulls in a patch to the config framework from Matt Jordan's CDR rework to handle config sections that should be ignored and a patch from David Lee's playback work for ast_channel_snapshot_get_latest().


Bugs: ASTERISK-21563
    https://issues.asterisk.org/jira/browse/ASTERISK-21563


Repository: Asterisk


Description (updated)
-------

This uses the channel state change events from Stasis-Core to determine when channel-related CEL events should be raised. Those refactored in this patch are:
* AST_CEL_CHANNEL_START
* AST_CEL_ANSWER
* AST_CEL_APP_START
* AST_CEL_APP_END
* AST_CEL_HANGUP
* AST_CEL_CHANNEL_END

Retirement of Linked IDs is also refactored.

Note: Some HANGUP events are not generated correctly because the bridge layer does not propagate hangupcause/hangupsource information yet (there are already BUGBUGs for this).


Diffs (updated)
-----

  trunk/include/asterisk/config_options.h 389448 
  trunk/include/asterisk/stasis_bridging.h 389448 
  trunk/include/asterisk/stasis_channels.h 389448 
  trunk/include/asterisk/strings.h 389448 
  trunk/main/asterisk.c 389448 
  trunk/main/cel.c 389448 
  trunk/main/channel.c 389448 
  trunk/main/config_options.c 389448 
  trunk/main/pbx.c 389448 
  trunk/main/stasis_bridging.c 389448 
  trunk/main/stasis_channels.c 389448 

Diff: https://reviewboard.asterisk.org/r/2544/diff/


Testing
-------

Ran these changes through all integration tests that check CEL records.


Thanks,

opticron

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130521/2412ebe5/attachment.htm>