<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2544/">https://reviewboard.asterisk.org/r/2544/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated May 21, 2013, 5:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Address comments and apply sadnessectomy. This pulls in a patch to the config framework from Matt Jordan's CDR rework to handle config sections that should be ignored and a patch from David Lee's playback work for ast_channel_snapshot_get_latest().</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21563">ASTERISK-21563</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This uses the channel state change events from Stasis-Core to determine when channel-related CEL events should be raised. Those refactored in this patch are:
* AST_CEL_CHANNEL_START
* AST_CEL_ANSWER
* AST_CEL_APP_START
* AST_CEL_APP_END
* AST_CEL_HANGUP
* AST_CEL_CHANNEL_END
Retirement of Linked IDs is also refactored.
Note: Some HANGUP events are not generated correctly because the bridge layer does not propagate hangupcause/hangupsource information yet (there are already BUGBUGs for this).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran these changes through all integration tests that check CEL records.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/include/asterisk/config_options.h <span style="color: grey">(389448)</span></li>
<li>trunk/include/asterisk/stasis_bridging.h <span style="color: grey">(389448)</span></li>
<li>trunk/include/asterisk/stasis_channels.h <span style="color: grey">(389448)</span></li>
<li>trunk/include/asterisk/strings.h <span style="color: grey">(389448)</span></li>
<li>trunk/main/asterisk.c <span style="color: grey">(389448)</span></li>
<li>trunk/main/cel.c <span style="color: grey">(389448)</span></li>
<li>trunk/main/channel.c <span style="color: grey">(389448)</span></li>
<li>trunk/main/config_options.c <span style="color: grey">(389448)</span></li>
<li>trunk/main/pbx.c <span style="color: grey">(389448)</span></li>
<li>trunk/main/stasis_bridging.c <span style="color: grey">(389448)</span></li>
<li>trunk/main/stasis_channels.c <span style="color: grey">(389448)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2544/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>