[asterisk-dev] [Code Review] 2544: Refactor CEL channel events on top of Stasis-Core

[rmudgett]

> On May 17, 2013, 1:59 a.m., Matt Jordan wrote:
> > trunk/main/stasis_channels.c, lines 130-140
> > <https://reviewboard.asterisk.org/r/2544/diff/3/?file=37987#file37987line130>
> >
> >     Just as mentioning the usage of optimizing Local channels during internal transfer operations that does not involve dialplan execution will cause me to rage, so too does reaching across a bridge to grab the bridged channel cause Richard to burst into righteous anger.
> >     
> >     You don't know that you have a single bridged channel. This function is doomed to die.

The ast_bridged_channel() function *will* be removed.  The only reason it still exists is the callers have not been fixed to not use it anymore.  Most of the callers are channel drivers doing it for transfer code.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2544/#review8644
-----------------------------------------------------------


On May 15, 2013, 9:01 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2544/
> -----------------------------------------------------------
> 
> (Updated May 15, 2013, 9:01 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21563
>     https://issues.asterisk.org/jira/browse/ASTERISK-21563
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This uses the channel state change events from Stasis-Core to determine when channel-related CEL events should be raised. Those refactored in this patch are:
> * AST_CEL_CHANNEL_START
> * AST_CEL_ANSWER
> * AST_CEL_APP_START
> * AST_CEL_APP_END
> * AST_CEL_HANGUP
> * AST_CEL_CHANNEL_END
> 
> Retirement of Linked IDs is also refactored.
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/stasis_channels.h 388883 
>   trunk/main/cel.c 388883 
>   trunk/main/channel.c 388883 
>   trunk/main/pbx.c 388883 
>   trunk/main/stasis_channels.c 388883 
> 
> Diff: https://reviewboard.asterisk.org/r/2544/diff/
> 
> 
> Testing
> -------
> 
> Ran these changes through all integration tests that check CEL records.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130517/598a435a/attachment-0001.htm>