[asterisk-dev] [Code Review] 2477: Sorcery Observers + Preliminary JSON Support

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2477/#review8413
-----------------------------------------------------------

Ship it!



/trunk/main/sorcery.c
<https://reviewboard.asterisk.org/r/2477/#comment16232>

    Since sorcery_observer_notify_loaded() never returns CMP_MATCH, there's no need to pass OBJ_MULTIPLE to ao2_callback(). This appears to be done in the other observer callbacks as well.


- Mark Michelson


On April 27, 2013, 10:31 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2477/
> -----------------------------------------------------------
> 
> (Updated April 27, 2013, 10:31 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change adds the following to sorcery:
> 
> 1. Observers
> 
> Observers can be added to a sorcery object type and get called when create, update, delete, or load/reload operations occur. An observer can implement only the specific operations it is interested in. Observers are called from a separate thread in a serialized fashion so that the thread calling the sorcery API is minimally impacted.
> 
> 2. Test for observers
> 
> A unit test has been added that confirms that observers are called for the different operations.
> 
> 3. Preliminary JSON Support
> 
> A new API call has been added which returns a JSON object representing a sorcery object.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/sorcery.h 386730 
>   /trunk/main/sorcery.c 386731 
>   /trunk/res/res_sorcery_astdb.c 386730 
>   /trunk/tests/test_sorcery.c 386730 
> 
> Diff: https://reviewboard.asterisk.org/r/2477/diff/
> 
> 
> Testing
> -------
> 
> Ran sorcery unit tests, confirmed happy.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130501/7f772b62/attachment.htm>