<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2477/">https://reviewboard.asterisk.org/r/2477/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2477/diff/1/?file=36531#file36531line704" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/main/sorcery.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">704</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">ao2_callback</span><span class="p">(</span><span class="n">invocation</span><span class="o">-></span><span class="n">object_type</span><span class="o">-></span><span class="n">observers</span><span class="p">,</span> <span class="n">OBJ_NODATA</span> <span class="o">|</span> <span class="n">OBJ_MULTIPLE</span><span class="p">,</span> <span class="n">sorcery_observer_notify_loaded</span><span class="p">,</span> <span class="n">invocation</span><span class="o">-></span><span class="n">object_type</span><span class="o">-></span><span class="n">name</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since sorcery_observer_notify_loaded() never returns CMP_MATCH, there's no need to pass OBJ_MULTIPLE to ao2_callback(). This appears to be done in the other observer callbacks as well.</pre>
</div>
<br />
<p>- Mark</p>
<br />
<p>On April 27th, 2013, 10:31 p.m. UTC, Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated April 27, 2013, 10:31 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change adds the following to sorcery:
1. Observers
Observers can be added to a sorcery object type and get called when create, update, delete, or load/reload operations occur. An observer can implement only the specific operations it is interested in. Observers are called from a separate thread in a serialized fashion so that the thread calling the sorcery API is minimally impacted.
2. Test for observers
A unit test has been added that confirms that observers are called for the different operations.
3. Preliminary JSON Support
A new API call has been added which returns a JSON object representing a sorcery object.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran sorcery unit tests, confirmed happy.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/include/asterisk/sorcery.h <span style="color: grey">(386730)</span></li>
<li>/trunk/main/sorcery.c <span style="color: grey">(386731)</span></li>
<li>/trunk/res/res_sorcery_astdb.c <span style="color: grey">(386730)</span></li>
<li>/trunk/tests/test_sorcery.c <span style="color: grey">(386730)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2477/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>