[asterisk-dev] [Code Review] 2463: Asterisk doesn't honor Session-Expires in 200OK response when it's a RE-INVITE when asterisk is the refresher.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2463/#review8415
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On April 22, 2013, 10:26 p.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2463/
> -----------------------------------------------------------
> 
> (Updated April 22, 2013, 10:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: 21664
>     https://issues.asterisk.org/jira/browse/21664
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Refer to:
> RFC 4028 Section 7.2
>  "UACs MUST be prepared to receive a Session-Expires header field in a
>  response, even if none were present in the request." 
> 
> Senario's below have 'Supported: timer' header: value
> Prior to since ASTERISK-20787
>   Devices making an inbound call to asterisk that didn't include a Session-Expires header in the INVITE, wouldn't be refreshed, thus wouldn't clear down should the connection be broken.
> 
> After ASTERISK-20787
>   Inbound calls to asterisk with no Session-Expires in the INVITE are now are offered a Session-Expires (1800 asterisk default) in the response, with asterisk being the refresher.
>   The issue is after the first RE-INVITE from asterisk (900 seconds), the device may respond with a much lower Session-Expires (180 in our case) value that it is now using.
>   Asterisk ignores this response, as it's deemed both an INBOUND CALL, and a RE-INVITE.
>   The result, after 180 more seconds the device is going to time out and hangup, asterisk is still working with the refresher period of 1800 as it ignored the 'Session Expires: 180' in the previous 200OK response.
>  
> 
> 
> Diffs
> -----
> 
>   branches/1.8/channels/chan_sip.c 386047 
> 
> Diff: https://reviewboard.asterisk.org/r/2463/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alec Davis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130501/151e2d04/attachment.htm>