[asterisk-dev] [Code Review] Pimp Sip: Video support

Kevin Harwell reviewboard at asterisk.org
Wed Mar 20 17:35:42 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2408/
-----------------------------------------------------------

Review request for Asterisk Developers and Joshua Colp.


Summary
-------

Adds video media handling support to the new SIP work being done in Asterisk.  Similar to audio added res_sip_sdp_video.c to handle sdp media negotiations for video.  Added capabilities support to make sure the correct codecs were being offered.  Also added the ability to handle the video source update control frame and initiate a fast video update request when needed.


This addresses bug ASTERISK-21077.
    https://issues.asterisk.org/jira/browse/ASTERISK-21077


Diffs
-----

  /team/kharwell/pimp_sip_video/channels/chan_gulp.c 383498 
  /team/kharwell/pimp_sip_video/include/asterisk/res_sip_session.h 383498 
  /team/kharwell/pimp_sip_video/res/res_sip_sdp_video.c 383498 
  /team/kharwell/pimp_sip_video/res/res_sip_session.c 383498 

Diff: https://reviewboard.asterisk.org/r/2408/diff


Testing
-------

Using two softphones that support video was able to successfully connect, via asterisk, and view video.  Also monitored sip messages to make sure the appropriate media attributes were being propagated.


Thanks,

Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130320/f35f032e/attachment-0001.htm>


More information about the asterisk-dev mailing list