[asterisk-dev] [Code Review] Pimp Sip: Video support

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2408/
-----------------------------------------------------------

(Updated March 21, 2013, 11:54 a.m.)


Review request for Asterisk Developers and Joshua Colp.


Changes
-------

Addressed issues mentioned:

Added "caps" to res_sip_sdp_audio, removed invite request and placed a TODO comment about needing to create and send an INFO request.  Removed the response from the indication code, but responded instead within the video INFO supplement handler.  Also updated mentioned areas to conform to the coding guidelines and renamed variables to be more helpful.


Summary
-------

Adds video media handling support to the new SIP work being done in Asterisk.  Similar to audio added res_sip_sdp_video.c to handle sdp media negotiations for video.  Added capabilities support to make sure the correct codecs were being offered.  Also added the ability to handle the video source update control frame and initiate a fast video update request when needed.


This addresses bug ASTERISK-21077.
    https://issues.asterisk.org/jira/browse/ASTERISK-21077


Diffs (updated)
-----

  /team/group/pimp_my_sip/channels/chan_gulp.c 383518 
  /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 383518 
  /team/group/pimp_my_sip/res/res_sip_sdp_audio.c 383518 
  /team/group/pimp_my_sip/res/res_sip_sdp_video.c PRE-CREATION 
  /team/group/pimp_my_sip/res/res_sip_session.c 383518 

Diff: https://reviewboard.asterisk.org/r/2408/diff


Testing
-------

Using two softphones that support video was able to successfully connect, via asterisk, and view video.  Also monitored sip messages to make sure the appropriate media attributes were being propagated.


Thanks,

Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130321/b80cf80a/attachment.htm>