[asterisk-dev] [Code Review] Add directed pickup to features

[wedhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2393/
-----------------------------------------------------------

(Updated March 18, 2013, 3:22 p.m.)


Review request for Asterisk Developers.


Changes
-------

Updated diff incorporating all of rmudgett's changes.

Also, patches currently include both directed pickup and call groups for skinny and sip. Sip however doesn't have the pickup functionality so should probably just include directed callgroup. Should probably also include directed callgroups for the other channels. Comments?


Summary
-------

Added ast_pickup_call_directed to features. Included some refactoring of ast_pickup_call to reuse same code.

In order to use ast_pickup_call, the chan passed in must have the exten set of the intended target. Will only pickup the target if the exten's match and the pickupgroupdirected and callgroupdirected of the chans match.

Also add ast_channel_callgroupdirected and ast_channel_pickupgroupdirected functions (and set functions) including code to set both of these in skinny and sip.

Code to actually do a directed pickup included in skinny.


Diffs (updated)
-----

  /trunk/CHANGES 383304 
  /trunk/channels/chan_sip.c 383304 
  /trunk/channels/chan_skinny.c 383304 
  /trunk/channels/sip/include/sip.h 383304 
  /trunk/configs/sip.conf.sample 383304 
  /trunk/configs/skinny.conf.sample 383304 
  /trunk/include/asterisk/channel.h 383304 
  /trunk/include/asterisk/features.h 383304 
  /trunk/main/channel_internal_api.c 383304 
  /trunk/main/features.c 383304 

Diff: https://reviewboard.asterisk.org/r/2393/diff


Testing
-------

Directed pickup to non ringing skinny and non ringing sip device (with matching and unset groups). Returns without picking up.

Directed pickup to ringing skinny and ringing sip device, with matching groups, picks up call, with unmatching groups return without pickup.


Thanks,

wedhorn

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130318/98465294/attachment.htm>