[asterisk-dev] [Code Review] Add directed pickup to features

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2393/#review8074
-----------------------------------------------------------


Since this is a new feature you also need to update CHANGES and document the new configuration parameters in the sample config files.


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2393/#comment15512>

    How about following the naming pattern precedented by
    named_callgroups
    named_pickupgroups
    throughout the patch, then it would be
    directed_callgroups
    directed_pickupgroups
    for consistency.



/trunk/include/asterisk/features.h
<https://reviewboard.asterisk.org/r/2393/#comment15513>

    Add a note that the chan exten must be set to the exten to pickup.



/trunk/include/asterisk/features.h
<https://reviewboard.asterisk.org/r/2393/#comment15514>

    Space after directed:
    directed */
    



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2393/#comment15508>

    Delete this line.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2393/#comment15509>

    Space after comma.



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2393/#comment15511>

    This is a good \brief comment for find_oldest_channel().



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2393/#comment15510>

    targets by exten



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2393/#comment15516>

    Also add a more explicit note that the chan exten must be set to the exten to pickup.


- rmudgett


On March 16, 2013, 6:50 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2393/
> -----------------------------------------------------------
> 
> (Updated March 16, 2013, 6:50 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Added ast_pickup_call_directed to features. Included some refactoring of ast_pickup_call to reuse same code.
> 
> In order to use ast_pickup_call, the chan passed in must have the exten set of the intended target. Will only pickup the target if the exten's match and the pickupgroupdirected and callgroupdirected of the chans match.
> 
> Also add ast_channel_callgroupdirected and ast_channel_pickupgroupdirected functions (and set functions) including code to set both of these in skinny and sip.
> 
> Code to actually do a directed pickup included in skinny.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 383304 
>   /trunk/channels/chan_skinny.c 383304 
>   /trunk/channels/sip/include/sip.h 383304 
>   /trunk/include/asterisk/channel.h 383304 
>   /trunk/include/asterisk/features.h 383304 
>   /trunk/main/channel_internal_api.c 383304 
>   /trunk/main/features.c 383304 
> 
> Diff: https://reviewboard.asterisk.org/r/2393/diff
> 
> 
> Testing
> -------
> 
> Directed pickup to non ringing skinny and non ringing sip device (with matching and unset groups). Returns without picking up.
> 
> Directed pickup to ringing skinny and ringing sip device, with matching groups, picks up call, with unmatching groups return without pickup.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130318/5273b23f/attachment-0001.htm>