[asterisk-dev] [Code Review] Add directed pickup to features

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2393/#review8084
-----------------------------------------------------------


I am wondering about the use case for these new parameters since the feature seems to be skinny specific.
How could a user know what extension they are wanting to pickup?
Do they somehow get a list of ringing extensions to pick from?



/trunk/CHANGES
<https://reviewboard.asterisk.org/r/2393/#comment15528>

    This is describing an Asterisk internal detail that a user is not going to care about.  The user will care about the new config parameters.
    
    Also blob.



/trunk/configs/skinny.conf.sample
<https://reviewboard.asterisk.org/r/2393/#comment15526>

    blobs



/trunk/main/features.c
<https://reviewboard.asterisk.org/r/2393/#comment15527>

    You might want to look at the Pickup application for finding the exten selects channels in ast_channel_iterator_by_exten_new()/ast_channel_by_exten_cb().  Your target may be in a macro.
    
    Passing in the exten to search for set in the channel does seem a bit awkward for more general use.  Probably should also specify a context or you may get more target matches than intended.


- rmudgett


On March 18, 2013, 3:22 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2393/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 3:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Added ast_pickup_call_directed to features. Included some refactoring of ast_pickup_call to reuse same code.
> 
> In order to use ast_pickup_call, the chan passed in must have the exten set of the intended target. Will only pickup the target if the exten's match and the pickupgroupdirected and callgroupdirected of the chans match.
> 
> Also add ast_channel_callgroupdirected and ast_channel_pickupgroupdirected functions (and set functions) including code to set both of these in skinny and sip.
> 
> Code to actually do a directed pickup included in skinny.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 383304 
>   /trunk/channels/chan_sip.c 383304 
>   /trunk/channels/chan_skinny.c 383304 
>   /trunk/channels/sip/include/sip.h 383304 
>   /trunk/configs/sip.conf.sample 383304 
>   /trunk/configs/skinny.conf.sample 383304 
>   /trunk/include/asterisk/channel.h 383304 
>   /trunk/include/asterisk/features.h 383304 
>   /trunk/main/channel_internal_api.c 383304 
>   /trunk/main/features.c 383304 
> 
> Diff: https://reviewboard.asterisk.org/r/2393/diff
> 
> 
> Testing
> -------
> 
> Directed pickup to non ringing skinny and non ringing sip device (with matching and unset groups). Returns without picking up.
> 
> Directed pickup to ringing skinny and ringing sip device, with matching groups, picks up call, with unmatching groups return without pickup.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130319/0f07e5e9/attachment-0001.htm>