[asterisk-dev] [Code Review] 2601: PeerEvent Migration to Stasis, and chan_pjsip Devicestate

Joshua Colp reviewboard at asterisk.org
Thu Jun 13 07:14:00 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2601/
-----------------------------------------------------------

(Updated June 13, 2013, 12:13 p.m.)


Review request for Asterisk Developers.


Repository: Asterisk


Description
-------

The attached changes implement the following:

1. Migrates the PeerStatus manager event to using Stasis.

Anything generating the PeerStatus event now does so by creating a stasis message and attaching a JSON blob.

2. Adds internal endpoints to some channel drivers.

To allow the above to occur some channel drivers now have endpoints on them.

3. chan_pjsip endpoint support.

chan_pjsip will now create a persistent endpoint which is used for the below device state support.

4. chan_pjsip devicestate support.

chan_pjsip now has device state support! Unlike other channel drivers this uses stasis to derive the current device state based on endpoint state and active channels.


Diffs (updated)
-----

  /trunk/channels/chan_gulp.c 391595 
  /trunk/channels/chan_iax2.c 391595 
  /trunk/channels/chan_sip.c 391595 
  /trunk/channels/chan_skinny.c 391595 
  /trunk/include/asterisk/manager.h 391595 
  /trunk/include/asterisk/res_sip.h 391595 
  /trunk/include/asterisk/stasis_endpoints.h 391596 
  /trunk/main/manager.c 391595 
  /trunk/main/stasis_endpoints.c 391596 
  /trunk/res/res_sip.c 391595 
  /trunk/res/res_sip/sip_configuration.c 391595 

Diff: https://reviewboard.asterisk.org/r/2601/diff/


Testing
-------

Exercised the various channel drivers to ensure that the manager events are going out.

Placed tons of calls with different scenarios with chan_pjsip to ensure that the device state changes to what is expected, and it does.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130613/3439f89b/attachment.htm>


More information about the asterisk-dev mailing list