<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2601/">https://reviewboard.asterisk.org/r/2601/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated June 13, 2013, 12:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The attached changes implement the following:
1. Migrates the PeerStatus manager event to using Stasis.
Anything generating the PeerStatus event now does so by creating a stasis message and attaching a JSON blob.
2. Adds internal endpoints to some channel drivers.
To allow the above to occur some channel drivers now have endpoints on them.
3. chan_pjsip endpoint support.
chan_pjsip will now create a persistent endpoint which is used for the below device state support.
4. chan_pjsip devicestate support.
chan_pjsip now has device state support! Unlike other channel drivers this uses stasis to derive the current device state based on endpoint state and active channels.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Exercised the various channel drivers to ensure that the manager events are going out.
Placed tons of calls with different scenarios with chan_pjsip to ensure that the device state changes to what is expected, and it does.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_gulp.c <span style="color: grey">(391595)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(391595)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(391595)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(391595)</span></li>
<li>/trunk/include/asterisk/manager.h <span style="color: grey">(391595)</span></li>
<li>/trunk/include/asterisk/res_sip.h <span style="color: grey">(391595)</span></li>
<li>/trunk/include/asterisk/stasis_endpoints.h <span style="color: grey">(391596)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(391595)</span></li>
<li>/trunk/main/stasis_endpoints.c <span style="color: grey">(391596)</span></li>
<li>/trunk/res/res_sip.c <span style="color: grey">(391595)</span></li>
<li>/trunk/res/res_sip/sip_configuration.c <span style="color: grey">(391595)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2601/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>