[asterisk-dev] [Code Review] 2601: PeerEvent Migration to Stasis, and chan_pjsip Devicestate

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2601/#review8875
-----------------------------------------------------------



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/2601/#comment17422>

    We've been lower-casing and un-CamelCasing the keys for JSON messages, i.e., peer_status instead of PeerStatus.
    
    Yes, that means that parsing these out is more bothersome; however, with David's to_ami/to_json callbacks it's not very bothersome.



/trunk/main/manager_endpoints.c
<https://reviewboard.asterisk.org/r/2601/#comment17423>

    We'll need AMI event documentation for this event as well.


- Matt Jordan


On June 7, 2013, 12:55 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2601/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 12:55 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The attached changes implement the following:
> 
> 1. Migrates the PeerStatus manager event to using Stasis.
> 
> Anything generating the PeerStatus event now does so by creating a stasis message and attaching a JSON blob.
> 
> 2. Adds internal endpoints to some channel drivers.
> 
> To allow the above to occur some channel drivers now have endpoints on them.
> 
> 3. chan_pjsip endpoint support.
> 
> chan_pjsip will now create a persistent endpoint which is used for the below device state support.
> 
> 4. chan_pjsip devicestate support.
> 
> chan_pjsip now has device state support! Unlike other channel drivers this uses stasis to derive the current device state based on endpoint state and active channels.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_gulp.c 390667 
>   /trunk/channels/chan_iax2.c 390667 
>   /trunk/channels/chan_sip.c 390667 
>   /trunk/channels/chan_skinny.c 390667 
>   /trunk/include/asterisk/manager.h 390667 
>   /trunk/include/asterisk/res_sip.h 390667 
>   /trunk/include/asterisk/stasis_endpoints.h 390667 
>   /trunk/main/manager.c 390667 
>   /trunk/main/manager_endpoints.c PRE-CREATION 
>   /trunk/main/stasis_endpoints.c 390667 
>   /trunk/res/res_sip.c 390667 
>   /trunk/res/res_sip/sip_configuration.c 390667 
> 
> Diff: https://reviewboard.asterisk.org/r/2601/diff/
> 
> 
> Testing
> -------
> 
> Exercised the various channel drivers to ensure that the manager events are going out.
> 
> Placed tons of calls with different scenarios with chan_pjsip to ensure that the device state changes to what is expected, and it does.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130610/254ff0be/attachment-0001.htm>