[asterisk-dev] [Code Review] 2620: bridge features: Make one touch Monitor and MixMonitor into bridge features

[jrose]

> On June 28, 2013, 2:24 p.m., Joshua Colp wrote:
> > /trunk/bridges/bridge_builtin_features.c, line 526
> > <https://reviewboard.asterisk.org/r/2620/diff/6-7/?file=40460#file40460line526>
> >
> >     Why the use of a goto? You are just going to do one thing anyway...
> 
> jrose wrote:
>     Eh, I must have started out thinking I might need to do more but decided that all the resource freeing would get handled by the function that called it.

Oooh, I know why now.  I was going to put a channel unlock there but forgot to. I almost shipped something that would always hold a lock on allocation failure.

I'll fix it using a scoped channel lock.


- jrose


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2620/#review9007
-----------------------------------------------------------


On June 27, 2013, 6:22 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2620/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 6:22 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: asterisk-21553
>     https://issues.asterisk.org/jira/browse/asterisk-21553
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds Monitor and MixMonitor as bridge features.  In order to avoid using PBX execution and autoservice, I added some additional API for MixMonitor provided through loadable function callbacks provided by app_mixmonitor.
> 
> In order to make One Touch MixMonitor behave more like its Monitor equivalent, I went ahead and added a couple channel variables for playing start and stop recording sounds (TOUCH_MIXMONITOR_MESSAGE_START and TOUCH_MIXMONITOR_MESSAGE_STOP)
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 392970 
>   /trunk/apps/app_mixmonitor.c 392970 
>   /trunk/bridges/bridge_builtin_features.c 392970 
>   /trunk/configs/features.conf.sample 392970 
>   /trunk/include/asterisk/channel.h 392970 
>   /trunk/include/asterisk/features_config.h 392970 
>   /trunk/include/asterisk/mixmonitor.h PRE-CREATION 
>   /trunk/main/features_config.c 392970 
>   /trunk/main/mixmonitor.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2620/diff/
> 
> 
> Testing
> -------
> 
> Tried both Monitor and MixMonitor with various channel variables set for filename/format and start/stop sounds. They appear to be working as one would expect.
> Also checked the behavior of MixMonitor with app_mixmonitor loaded and unloaded. As expected, it is rejected smoothly when MixMonitor is not loaded.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130701/b6d4c127/attachment.htm>