[asterisk-dev] [Code Review] 2620: bridge features: Make one touch Monitor and MixMonitor into bridge features

svnbot reviewboard at asterisk.org
Mon Jul 1 11:01:27 CDT 2013

This is an automatically generated e-mail. To reply, visit:

(Updated July 1, 2013, 11:01 a.m.)


This change has been marked as submitted.

Review request for Asterisk Developers, Matt Jordan and rmudgett.


Committed in revision 393309

Bugs: asterisk-21553

Repository: Asterisk


Adds Monitor and MixMonitor as bridge features.  In order to avoid using PBX execution and autoservice, I added some additional API for MixMonitor provided through loadable function callbacks provided by app_mixmonitor.

In order to make One Touch MixMonitor behave more like its Monitor equivalent, I went ahead and added a couple channel variables for playing start and stop recording sounds (TOUCH_MIXMONITOR_MESSAGE_START and TOUCH_MIXMONITOR_MESSAGE_STOP)


  /trunk/CHANGES 392970 
  /trunk/apps/app_mixmonitor.c 392970 
  /trunk/bridges/bridge_builtin_features.c 392970 
  /trunk/configs/features.conf.sample 392970 
  /trunk/include/asterisk/channel.h 392970 
  /trunk/include/asterisk/features_config.h 392970 
  /trunk/include/asterisk/mixmonitor.h PRE-CREATION 
  /trunk/main/features_config.c 392970 
  /trunk/main/mixmonitor.c PRE-CREATION 

Diff: https://reviewboard.asterisk.org/r/2620/diff/


Tried both Monitor and MixMonitor with various channel variables set for filename/format and start/stop sounds. They appear to be working as one would expect.
Also checked the behavior of MixMonitor with app_mixmonitor loaded and unloaded. As expected, it is rejected smoothly when MixMonitor is not loaded.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130701/c509e773/attachment.htm>

More information about the asterisk-dev mailing list