[asterisk-dev] [Code Review] 2648: func_channel: set dtmf_features

svnbot reviewboard at asterisk.org
Tue Jul 23 16:32:36 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2648/
-----------------------------------------------------------

(Updated July 23, 2013, 4:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers, Matt Jordan and rmudgett.


Changes
-------

Committed in revision 395215


Bugs: ASTERISK-21876
    https://issues.asterisk.org/jira/browse/ASTERISK-21876


Repository: Asterisk


Description
-------

Allows setting dtmf features via a channel set function (namely CHANNEL(dtmf_features)


Diffs
-----

  /trunk/funcs/func_channel.c 395071 
  /trunk/include/asterisk/bridging_basic.h 395071 
  /trunk/main/bridging_basic.c 395071 

Diff: https://reviewboard.asterisk.org/r/2648/diff/


Testing
-------

Stuck two channels in the following extension:

exten => 10,1,NoOp
exten => 10,n,Answer()
exten => 10,n,Set(CHANNEL(dtmf_features)=wktx)
exten => 10,n,Wait(50)

Then bridged them together with the manager bridge command and checked to see if both channels could park, transfer, and attended transfer.

It's worth noting that the dial application overrides this datastore entirely, so these don't get applied to dial as-is. This might need to be addressed.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130723/dbd5f155/attachment.htm>


More information about the asterisk-dev mailing list