[asterisk-dev] [Code Review] Allow for arbitrary redirectingreasons

[Alec Davis]

There's another 829 of these
 
grep --include=*.c -ri '[a-z]\*\/' . |wc
 


  _____  

From: asterisk-dev-bounces at lists.digium.com
[mailto:asterisk-dev-bounces at lists.digium.com] On Behalf Of rmudgett
Sent: Saturday, 8 September 2012 11:38 a.m.
To: rmudgett at digium.com
Cc: rmudgett; Asterisk Developers
Subject: Re: [asterisk-dev] [Code Review] Allow for arbitrary
redirectingreasons


This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2101/ 	


Ship it!

Just a minor style nit pick.

/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2101/diff/1/?file=31155#file31155line107
23>  (Diff revision 1) 	

int ast_redirecting_parse_data(const unsigned char *data, size_t datalen,
struct ast_party_redirecting *redirecting)
	
10707	 /* Redirecting orig-reason code*/
Missing space before comment close.


- rmudgett


On September 7th, 2012, 4:24 p.m., Mark Michelson wrote:


Review request for Asterisk Developers and rmudgett.
By Mark Michelson.

Updated Sept. 7, 2012, 4:24 p.m.


Description 


This patch modifies the ast_party_redirecting structure's reason and
orig_reason fields by making them structures that contain both an integer
code and a string. This allows for arbitrary reasons beyond any that are
predefined. This allows for a wide array of reasons to be read from the
dialplan by inspecting ${REDIRECTING(reason)}.



chan_sip.c has been modified to read in the strings from a Diversion header
and set the redirecting.reason.str field accordingly. Similarly, chan_sip.c
has been modified to send out the reason as a quoted string in a Diversion
header. chan_sip.c has also been modified to read the reason-text of a 480
response as a redirecting reason string as well.

Testing 


There is an accompanying test that will be going in alongside this code.
Bugs: AST-942 <https://issues.asterisk.org/jira/browse/AST-942> , AST-943
<https://issues.asterisk.org/jira/browse/AST-943>  

Diffs 


*	/trunk/channels/chan_misdn.c (372318) 

*	/trunk/channels/chan_sip.c (372318) 

*	/trunk/channels/sig_pri.c (372318) 

*	/trunk/funcs/func_callerid.c (372318) 

*	/trunk/include/asterisk/callerid.h (372318) 

*	/trunk/include/asterisk/channel.h (372318) 

*	/trunk/main/callerid.c (372318) 

*	/trunk/main/channel.c (372318) 

View  <https://reviewboard.asterisk.org/r/2101/diff/> Diff

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120908/be496dff/attachment.htm>