<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=us-ascii" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 9.00.8112.16448"></HEAD>
<BODY>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=636070200-08092012>There's another 829 of these</SPAN></FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial><SPAN
class=636070200-08092012></SPAN></FONT> </DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2 face=Arial>grep --include=*.c
-ri '[a-z]\*\/' . |wc</FONT></DIV>
<DIV dir=ltr align=left><FONT color=#0000ff size=2
face=Arial></FONT> </DIV><BR>
<BLOCKQUOTE
style="BORDER-LEFT: #0000ff 2px solid; PADDING-LEFT: 5px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px"
dir=ltr>
<DIV dir=ltr lang=en-us class=OutlookMessageHeader align=left>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> asterisk-dev-bounces@lists.digium.com
[mailto:asterisk-dev-bounces@lists.digium.com] <B>On Behalf Of
</B>rmudgett<BR><B>Sent:</B> Saturday, 8 September 2012 11:38
a.m.<BR><B>To:</B> rmudgett@digium.com<BR><B>Cc:</B> rmudgett; Asterisk
Developers<BR><B>Subject:</B> Re: [asterisk-dev] [Code Review] Allow for
arbitrary redirectingreasons<BR></FONT><BR></DIV>
<DIV></DIV>
<DIV style="FONT-FAMILY: Verdana, Arial, Helvetica, Sans-Serif">
<TABLE
style="BORDER-BOTTOM: #c9c399 1px solid; BORDER-LEFT: #c9c399 1px solid; BORDER-TOP: #c9c399 1px solid; BORDER-RIGHT: #c9c399 1px solid"
cellPadding=8 width="100%" bgColor=#f9f3c9>
<TBODY>
<TR>
<TD>This is an automatically generated e-mail. To reply, visit: <A
href="https://reviewboard.asterisk.org/r/2101/">https://reviewboard.asterisk.org/r/2101/</A>
</TD></TR></TBODY></TABLE><BR>
<P>Ship it!</P><PRE style="WORD-WRAP: break-word">Just a minor style nit pick.</PRE><BR>
<DIV>
<TABLE
style="BORDER-BOTTOM: #c0c0c0 1px solid; BORDER-LEFT: #c0c0c0 1px solid; MARGIN-TOP: 2px; BORDER-COLLAPSE: collapse; MARGIN-LEFT: 2px; BORDER-TOP: #c0c0c0 1px solid; MARGIN-RIGHT: 2px; BORDER-RIGHT: #c0c0c0 1px solid"
border=0 width="100%" bgColor=white>
<THEAD>
<TR>
<TH
style="BORDER-BOTTOM: #c0c0c0 1px solid; TEXT-ALIGN: left; PADDING-BOTTOM: 4px; PADDING-LEFT: 8px; PADDING-RIGHT: 8px; FONT-SIZE: 9pt; PADDING-TOP: 4px"
bgColor=#f0f0f0 colSpan=4><A
style="COLOR: black; FONT-WEIGHT: bold; TEXT-DECORATION: underline"
href="https://reviewboard.asterisk.org/r/2101/diff/1/?file=31155#file31155line10723">/trunk/main/channel.c</A>
<SPAN style="FONT-WEIGHT: normal">(Diff revision 1)
</SPAN></TH></TR></THEAD>
<TBODY
style="TEXT-ALIGN: center; PADDING-BOTTOM: 4px; BACKGROUND-COLOR: #e4d9cb; PADDING-LEFT: 8px; PADDING-RIGHT: 8px; PADDING-TOP: 4px">
<TR>
<TD colSpan=4><PRE style="LINE-HEIGHT: 140%; MARGIN: 0px; FONT-SIZE: 8pt">int ast_redirecting_parse_data(const unsigned char *data, size_t datalen, struct ast_party_redirecting *redirecting)</PRE></TD></TR></TBODY>
<TBODY>
<TR>
<TH style="BORDER-RIGHT: #c0c0c0 1px solid" bgColor=#b1ebb0
align=right><FONT size=2></FONT></TH>
<TD bgColor=#c5ffc4 width="50%"><PRE style="LINE-HEIGHT: 140%; MARGIN: 0px; FONT-SIZE: 8pt"></PRE></TD>
<TH
style="BORDER-LEFT: #c0c0c0 1px solid; BORDER-RIGHT: #c0c0c0 1px solid"
bgColor=#b1ebb0 align=right><FONT size=2>10707</FONT></TH>
<TD bgColor=#c5ffc4 width="50%"><PRE style="LINE-HEIGHT: 140%; MARGIN: 0px; FONT-SIZE: 8pt"><SPAN class=cm>/* Redirecting orig-reason code*/</SPAN></PRE></TD></TR></TBODY></TABLE><PRE style="WORD-WRAP: break-word; MARGIN-LEFT: 2em">Missing space before comment close.</PRE></DIV><BR>
<P>- rmudgett</P><BR>
<P>On September 7th, 2012, 4:24 p.m., Mark Michelson wrote:</P>
<TABLE
style="BACKGROUND-IMAGE: url(https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png); BORDER-BOTTOM: black 1px solid; BORDER-LEFT: black 1px solid; BACKGROUND-REPEAT: repeat-x; BACKGROUND-POSITION: left top; BORDER-TOP: black 1px solid; BORDER-RIGHT: black 1px solid"
cellSpacing=0 cellPadding=8 width="100%" bgColor=#fefadf>
<TBODY>
<TR>
<TD>
<DIV>Review request for Asterisk Developers and rmudgett.</DIV>
<DIV>By Mark Michelson.</DIV>
<P style="COLOR: grey"><I>Updated Sept. 7, 2012, 4:24 p.m.</I></P>
<H1
style="MARGIN-TOP: 1.5em; COLOR: #575012; FONT-SIZE: 10pt">Description
</H1>
<TABLE
style="BORDER-BOTTOM: #b8b5a0 1px solid; BORDER-LEFT: #b8b5a0 1px solid; BORDER-TOP: #b8b5a0 1px solid; BORDER-RIGHT: #b8b5a0 1px solid"
cellSpacing=0 cellPadding=10 width="100%" bgColor=#ffffff>
<TBODY>
<TR>
<TD><PRE style="PADDING-BOTTOM: 0px; MARGIN: 0px; PADDING-LEFT: 0px; PADDING-RIGHT: 0px; WORD-WRAP: break-word; PADDING-TOP: 0px">This patch modifies the ast_party_redirecting structure's reason and orig_reason fields by making them structures that contain both an integer code and a string. This allows for arbitrary reasons beyond any that are predefined. This allows for a wide array of reasons to be read from the dialplan by inspecting ${REDIRECTING(reason)}.
chan_sip.c has been modified to read in the strings from a Diversion header and set the redirecting.reason.str field accordingly. Similarly, chan_sip.c has been modified to send out the reason as a quoted string in a Diversion header. chan_sip.c has also been modified to read the reason-text of a 480 response as a redirecting reason string as well.</PRE></TD></TR></TBODY></TABLE>
<H1 style="MARGIN-TOP: 1.5em; COLOR: #575012; FONT-SIZE: 10pt">Testing
</H1>
<TABLE
style="BORDER-BOTTOM: #b8b5a0 1px solid; BORDER-LEFT: #b8b5a0 1px solid; BORDER-TOP: #b8b5a0 1px solid; BORDER-RIGHT: #b8b5a0 1px solid"
cellSpacing=0 cellPadding=10 width="100%" bgColor=#ffffff>
<TBODY>
<TR>
<TD><PRE style="PADDING-BOTTOM: 0px; MARGIN: 0px; PADDING-LEFT: 0px; PADDING-RIGHT: 0px; WORD-WRAP: break-word; PADDING-TOP: 0px">There is an accompanying test that will be going in alongside this code.</PRE></TD></TR></TBODY></TABLE>
<DIV style="MARGIN-TOP: 1.5em"><B
style="MARGIN-TOP: 1.5em; COLOR: #575012; FONT-SIZE: 10pt">Bugs: </B><A
href="https://issues.asterisk.org/jira/browse/AST-942">AST-942</A>, <A
href="https://issues.asterisk.org/jira/browse/AST-943">AST-943</A>
</DIV>
<H1 style="MARGIN-TOP: 1.5em; COLOR: #575012; FONT-SIZE: 10pt">Diffs</B>
</H1>
<UL style="PADDING-LEFT: 0px; MARGIN-LEFT: 3em">
<LI>/trunk/channels/chan_misdn.c <SPAN
style="COLOR: grey">(372318)</SPAN>
<LI>/trunk/channels/chan_sip.c <SPAN
style="COLOR: grey">(372318)</SPAN>
<LI>/trunk/channels/sig_pri.c <SPAN
style="COLOR: grey">(372318)</SPAN>
<LI>/trunk/funcs/func_callerid.c <SPAN
style="COLOR: grey">(372318)</SPAN>
<LI>/trunk/include/asterisk/callerid.h <SPAN
style="COLOR: grey">(372318)</SPAN>
<LI>/trunk/include/asterisk/channel.h <SPAN
style="COLOR: grey">(372318)</SPAN>
<LI>/trunk/main/callerid.c <SPAN style="COLOR: grey">(372318)</SPAN>
<LI>/trunk/main/channel.c <SPAN style="COLOR: grey">(372318)</SPAN>
</LI></UL>
<P><A style="MARGIN-LEFT: 3em"
href="https://reviewboard.asterisk.org/r/2101/diff/">View
Diff</A></P></TD></TR></TBODY></TABLE></DIV></BLOCKQUOTE></BODY></HTML>