[asterisk-dev] [Code Review] Allow for arbitrary redirecting reasons

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2101/#review7027
-----------------------------------------------------------

Ship it!


Just a minor style nit pick.


/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2101/#comment13632>

    Missing space before comment close.


- rmudgett


On Sept. 7, 2012, 4:24 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2101/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2012, 4:24 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Summary
> -------
> 
> This patch modifies the ast_party_redirecting structure's reason and orig_reason fields by making them structures that contain both an integer code and a string. This allows for arbitrary reasons beyond any that are predefined. This allows for a wide array of reasons to be read from the dialplan by inspecting ${REDIRECTING(reason)}.
> 
> chan_sip.c has been modified to read in the strings from a Diversion header and set the redirecting.reason.str field accordingly. Similarly, chan_sip.c has been modified to send out the reason as a quoted string in a Diversion header. chan_sip.c has also been modified to read the reason-text of a 480 response as a redirecting reason string as well.
> 
> 
> This addresses bugs AST-942 and AST-943.
>     https://issues.asterisk.org/jira/browse/AST-942
>     https://issues.asterisk.org/jira/browse/AST-943
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_misdn.c 372318 
>   /trunk/channels/chan_sip.c 372318 
>   /trunk/channels/sig_pri.c 372318 
>   /trunk/funcs/func_callerid.c 372318 
>   /trunk/include/asterisk/callerid.h 372318 
>   /trunk/include/asterisk/channel.h 372318 
>   /trunk/main/callerid.c 372318 
>   /trunk/main/channel.c 372318 
> 
> Diff: https://reviewboard.asterisk.org/r/2101/diff
> 
> 
> Testing
> -------
> 
> There is an accompanying test that will be going in alongside this code.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120907/45232898/attachment-0001.htm>