[asterisk-dev] [Code Review] dsp.c User Configurable DTMF_HITS_TO_BEGIN and DTMF_MISSES_TO_END

Alec Davis reviewboard at asterisk.org
Thu Oct 4 14:44:22 CDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2144/
-----------------------------------------------------------

(Updated Oct. 4, 2012, 2:44 p.m.)


Review request for Asterisk Developers and rmudgett.


Changes
-------

update bug referece


Summary
-------

Instead of a recompile, allow values to be adjusted in dsp.conf

For binary distributions allows easy adjustment for wobbly GSM calls, and other reasons.

Defaults to DTMF_HITS_TO_BEGIN=2 and DTMF_MISSES_TO_END=3

The sites I maintain here in NZ all require hits=4/misses=4 otherwise GSM calls into IVR don't work as expected.
I can of course recompile, but that shouldn't be required.


This addresses bug ASTERISK-17493.
    https://issues.asterisk.org/jira/browse/ASTERISK-17493


Diffs
-----

  branches/1.8/CHANGES 374413 
  branches/1.8/configs/dsp.conf.sample 374413 
  branches/1.8/main/dsp.c 374413 

Diff: https://reviewboard.asterisk.org/r/2144/diff


Testing
-------

Yes


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121004/6a615ba0/attachment.htm>


More information about the asterisk-dev mailing list