[asterisk-dev] [Code Review]: dsp.c User Configurable DTMF_HITS_TO_BEGIN and DTMF_MISSES_TO_END

[Alec Davis]

> On Oct. 4, 2012, 11:23 a.m., rmudgett wrote:
> > Looks good.
> > 
> > This is actually the fix for ASTERISK-17493.  The other issue you reference is against 1.4 and was closed because that branch had reached EOL.
> > You can also close ASTERISK-19610 again.

Richard: The patch sip_info_dtmf.diff.txt that I thought would fix ASTERISK-19610, would fix ASTERISK-20218 which was closed as a duplicate of 19610.
In 20218 in the attachment that both inband and SIP-info are enabled.

I got double DTMF END events when I enabled both 'inband' and 'sip-info' on a Grandstream GXP2000.


- Alec


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2144/#review7218
-----------------------------------------------------------


On Oct. 4, 2012, 2:30 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2144/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2012, 2:30 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Summary
> -------
> 
> Instead of a recompile, allow values to be adjusted in dsp.conf
> 
> For binary distributions allows easy adjustment for wobbly GSM calls, and other reasons.
> 
> Defaults to DTMF_HITS_TO_BEGIN=2 and DTMF_MISSES_TO_END=3
> 
> The sites I maintain here in NZ all require hits=4/misses=4 otherwise GSM calls into IVR don't work as expected.
> I can of course recompile, but that shouldn't be required.
> 
> 
> This addresses bug ASTERISK-20048.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20048
> 
> 
> Diffs
> -----
> 
>   branches/1.8/CHANGES 374413 
>   branches/1.8/configs/dsp.conf.sample 374413 
>   branches/1.8/main/dsp.c 374413 
> 
> Diff: https://reviewboard.asterisk.org/r/2144/diff
> 
> 
> Testing
> -------
> 
> Yes
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20121004/2aecda75/attachment.htm>