[asterisk-dev] [Code Review] Continuing from 1643 (Allow specifying which MixMonitor to Stop)

[Sean Bright]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1682/#review5243
-----------------------------------------------------------



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1682/#comment9769>

    Translate into English.



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1682/#comment9770>

    "ID associated *with* the MixMonitor to stop"



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1682/#comment9771>

    Ditto



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1682/#comment9772>

    const char *datastore_id



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1682/#comment9773>

    Maybe throw in a comment to explain this voodoo, or do sizeof("0x") instead of 3.



/trunk/apps/app_mixmonitor.c
<https://reviewboard.asterisk.org/r/1682/#comment9774>

    This output should be suitable for humans, so drop the CamelCasing and the underscores.


- Sean


On Jan. 20, 2012, 1:07 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1682/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2012, 1:07 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and telecos.
> 
> 
> Summary
> -------
> 
> Fixes style problems from r6 on https://reviewboard.asterisk.org/r/1643/
> Changes creation of character buffer to length of a pointer in characters + 3 (2 for 0x, 1 for terminating space)
> 
> That might not be adequate.  Richard was saying something about pointers on other operating systems having other dividing symbols in them.  Well, at least ':'s.
> 
> In my experiences though, a pointer is usually just something like 0x0123FEDC when printed with %p.
> 
> 
> This addresses bug ASTERISK-19096.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19096
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 351538 
>   /trunk/apps/app_mixmonitor.c 351538 
> 
> Diff: https://reviewboard.asterisk.org/r/1682/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120120/34c23419/attachment.htm>