[asterisk-dev] [Code Review]: Continuing from 1643 (Allow specifying which MixMonitor to Stop)

[telecos82]

> On Jan. 20, 2012, 2:17 p.m., Mark Michelson wrote:
> > /trunk/apps/app_mixmonitor.c, lines 825-827
> > <https://reviewboard.asterisk.org/r/1682/diff/1/?file=23496#file23496line825>
> >
> >     This change seems unrelated to the addition of stopping a mixmonitor by ID. Can you explain why it's here?
> 
> jrose wrote:
>     Nope.  I can't.  Perhaps Telecos can.

That's related with the deletion of line 764 of original file, where "ast_audiohook_detach_source" was called to detach a mixmonitor's audiohook from the channel with no control on the concrete mixmonitor being stopped. I used directly ast_audiohook_update_status, as is done inside ast_audiohook_detach_source, to perform such detach of the audiohook associated with the mixmonitor being stopped.


- telecos82


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1682/#review5242
-----------------------------------------------------------


On Jan. 20, 2012, 1:07 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1682/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2012, 1:07 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and telecos.
> 
> 
> Summary
> -------
> 
> Fixes style problems from r6 on https://reviewboard.asterisk.org/r/1643/
> Changes creation of character buffer to length of a pointer in characters + 3 (2 for 0x, 1 for terminating space)
> 
> That might not be adequate.  Richard was saying something about pointers on other operating systems having other dividing symbols in them.  Well, at least ':'s.
> 
> In my experiences though, a pointer is usually just something like 0x0123FEDC when printed with %p.
> 
> 
> This addresses bug ASTERISK-19096.
>     https://issues.asterisk.org/jira/browse/ASTERISK-19096
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 351538 
>   /trunk/apps/app_mixmonitor.c 351538 
> 
> Diff: https://reviewboard.asterisk.org/r/1682/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120120/80fdfb50/attachment.htm>