[asterisk-dev] [Code Review] Continuing from 1643 (Allow specifying which MixMonitor to Stop)

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1682/
-----------------------------------------------------------

(Updated Jan. 20, 2012, 4:02 p.m.)


Review request for Asterisk Developers, Mark Michelson and telecos.


Changes
-------

Addresses buffer issue among everything else mentioned.  I think.  There were a lot of them.  Also, see Telecos's comment above for that audio hook status thing.


Summary
-------

Fixes style problems from r6 on https://reviewboard.asterisk.org/r/1643/
Changes creation of character buffer to length of a pointer in characters + 3 (2 for 0x, 1 for terminating space)

That might not be adequate.  Richard was saying something about pointers on other operating systems having other dividing symbols in them.  Well, at least ':'s.

In my experiences though, a pointer is usually just something like 0x0123FEDC when printed with %p.


This addresses bug ASTERISK-19096.
    https://issues.asterisk.org/jira/browse/ASTERISK-19096


Diffs (updated)
-----

  /trunk/CHANGES 351538 
  /trunk/apps/app_mixmonitor.c 351538 

Diff: https://reviewboard.asterisk.org/r/1682/diff


Testing
-------


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120120/6c9a1a1f/attachment.htm>