[asterisk-dev] [Code Review] sync chan_dahdi->p->outgoing with sig_XXX->p-outgoing

Alec Davis reviewboard at asterisk.org
Fri Feb 17 02:54:04 CST 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1747/
-----------------------------------------------------------

(Updated Feb. 17, 2012, 2:54 a.m.)


Review request for Asterisk Developers.


Changes
-------

As Richard Mudgett suggested, sig_pri and sig_ss7 should also set the 'outgoing' flag the same way as sig_analog.


Summary (updated)
-------

Jeremy Pepper review https://reviewboard.asterisk.org/r/1737/ highlighted an issue where p->outgoing flag isn't in sync between chan_dahdi and sig_analog


Diffs (updated)
-----

  trunk/channels/chan_dahdi.c 353434 
  trunk/channels/sig_analog.h 353434 
  trunk/channels/sig_analog.c 353434 
  trunk/channels/sig_pri.h 353434 
  trunk/channels/sig_pri.c 353434 
  trunk/channels/sig_ss7.h 353434 
  trunk/channels/sig_ss7.c 353434 

Diff: https://reviewboard.asterisk.org/r/1747/diff


Testing (updated)
-------

sig_analog: Basic calls in and out with analog TDM800P
sig_pri and sig_ss7: compiles


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120217/11e30f7c/attachment.htm>


More information about the asterisk-dev mailing list