[asterisk-dev] [Code Review] sync chan_dahdi->p->outgoing with sig_XXX->p-outgoing

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1747/#review5547
-----------------------------------------------------------



trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1747/#comment10182>

    This should be added to the sig_pri and sig_ss7 table as well.



trunk/channels/sig_analog.c
<https://reviewboard.asterisk.org/r/1747/#comment10181>

    Is this needed to fix the outgoing flag so https://reviewboard.asterisk.org/r/1737/ can use it instead of the ast_channel flag?


- rmudgett


On Feb. 17, 2012, 2:54 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1747/
> -----------------------------------------------------------
> 
> (Updated Feb. 17, 2012, 2:54 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Jeremy Pepper review https://reviewboard.asterisk.org/r/1737/ highlighted an issue where p->outgoing flag isn't in sync between chan_dahdi and sig_analog
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 353434 
>   trunk/channels/sig_analog.h 353434 
>   trunk/channels/sig_analog.c 353434 
>   trunk/channels/sig_pri.h 353434 
>   trunk/channels/sig_pri.c 353434 
>   trunk/channels/sig_ss7.h 353434 
>   trunk/channels/sig_ss7.c 353434 
> 
> Diff: https://reviewboard.asterisk.org/r/1747/diff
> 
> 
> Testing
> -------
> 
> sig_analog: Basic calls in and out with analog TDM800P
> sig_pri and sig_ss7: compiles
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120217/75700aea/attachment-0001.htm>