[asterisk-dev] [Code Review] sync chan_dahdi->p->outgoing with sig_analog->p-outgoing

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1747/
-----------------------------------------------------------

(Updated Feb. 17, 2012, 2:06 a.m.)


Review request for Asterisk Developers.


Changes
-------

As close as I can get it to the style used by sig_pri p->digital ( i think like my first attempt ).

I agree richard, all of the sig_XXX code like sig_XXX_request, sig_XXX_call, sig_XXX_hangup should be using the same 'outgoing' call back method as we're proposing here for sig_analog.
Then the ~6 places where 'p->outgoing = 0/1' is set in chan_dahdi could go, except when not handled by any of the sig_XXX code. 


Summary
-------

Jeremy Pepper review https://reviewboard.asterisk.org/r/1737/ highlighted an issue where p->outgoing flag isn't in sync'd between chan_dahdi and sig_analog


Diffs (updated)
-----

  trunk/channels/sig_analog.h 353434 
  trunk/channels/chan_dahdi.c 353434 
  trunk/channels/sig_analog.c 353434 

Diff: https://reviewboard.asterisk.org/r/1747/diff


Testing
-------

Basic calls in and out with analog TDM800P


Thanks,

Alec

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120217/7ea15324/attachment.htm>