[asterisk-dev] [Code Review] sync chan_dahdi->p->outgoing with sig_analog->p-outgoing

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1747/#review5532
-----------------------------------------------------------


You should do it the same way as sig_pri does the digital flag.  The sig_xxx extraction was intended so the sig_xxx code did not need to use chan_dahdi as the upper layer and the upper layer may not supply the callback to check the outgoing flag.

That being said, sig_pri and sig_ss7 also have an outgoing flag but they avoid the callback because they implicitly keep the outgoing flags in sync.  Maybe they really should do the same as the digital flag anyway.

- rmudgett


On Feb. 16, 2012, 4:19 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1747/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2012, 4:19 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Jeremy Pepper review https://reviewboard.asterisk.org/r/1737/ highlighted an issue where p->outgoing flag isn't in sync'd between chan_dahdi and sig_analog
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_dahdi.c 353434 
>   trunk/channels/sig_analog.h 353434 
>   trunk/channels/sig_analog.c 353434 
> 
> Diff: https://reviewboard.asterisk.org/r/1747/diff
> 
> 
> Testing
> -------
> 
> Basic calls in and out with analog TDM800P
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120216/3a967175/attachment-0001.htm>