[asterisk-dev] [Code Review]: Changes from Mantis ID 13495 in trunk.

[Tilghman Lesher]

> On Aug. 17, 2012, 12:43 p.m., rmudgett wrote:
> > trunk/channels/chan_dahdi.c, lines 16746-16752
> > <https://reviewboard.asterisk.org/r/1676/diff/12/?file=30930#file30930line16746>
> >
> >     Where is the "reset" command word checked?

Carefully read both of the final two conditionals and then tell me when the last one will ever execute.  I think you're missing a '!' in the first one.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review6922
-----------------------------------------------------------


On Aug. 14, 2012, 8:02 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 8:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   trunk/configs/chan_dahdi.conf.sample 371240 
>   trunk/configs/ss7.timers.sample PRE-CREATION 
>   trunk/channels/sig_ss7.h 371240 
>   trunk/channels/sig_ss7.c 371240 
>   trunk/channels/chan_dahdi.c 371240 
>   trunk/configure.ac 371240 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120817/a0f42eed/attachment-0001.htm>