[asterisk-dev] [Code Review]: Changes from Mantis ID 13495 in trunk.

[KNK]

> On Aug. 17, 2012, 12:43 p.m., rmudgett wrote:
> > Using the code from this latest version, I am still getting the GRS / REL/RSC loop.

I can't trigger the loop here, but my guess is that got_sent_msg flags are not properly (re)set somewhere ... found few places in isup.c and attached the patch to the issue.


> On Aug. 17, 2012, 12:43 p.m., rmudgett wrote:
> > trunk/channels/chan_dahdi.c, lines 16766-16770
> > <https://reviewboard.asterisk.org/r/1676/diff/12/?file=30930#file30930line16766>
> >
> >     Cramming everything into one statement only makes the statement hard to understand and maintain.  Simplify, this by not using the ternary operator this way.  Just use if/else if logic.

Done


> On Aug. 17, 2012, 12:43 p.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, lines 1603-1607
> > <https://reviewboard.asterisk.org/r/1676/diff/12/?file=30932#file30932line1603>
> >
> >     Put the comment before the line setting chanpos here since that is what the comment is referring to.

Done


> On Aug. 17, 2012, 12:43 p.m., rmudgett wrote:
> > trunk/configs/chan_dahdi.conf.sample, line 1308
> > <https://reviewboard.asterisk.org/r/1676/diff/12/?file=30933#file30933line1308>
> >
> >     ; has not seen proceeding
> >     
> >     Just take the chan_dahdi.conf sample from the team/rmudgett/ss7_27_knk branch.  It also documents the new slc parameter that is missing in this diff.

Done.


> On Aug. 17, 2012, 12:43 p.m., rmudgett wrote:
> > trunk/configs/ss7.timers.sample, line 15
> > <https://reviewboard.asterisk.org/r/1676/diff/12/?file=30934#file30934line15>
> >
> >     This timer does not exist in the new libss7 code so I commented it out.

Removed completely


> On Aug. 17, 2012, 12:43 p.m., rmudgett wrote:
> > trunk/channels/chan_dahdi.c, lines 16746-16752
> > <https://reviewboard.asterisk.org/r/1676/diff/12/?file=30930#file30930line16746>
> >
> >     Where is the "reset" command word checked?
> 
> Tilghman Lesher wrote:
>     Carefully read both of the final two conditionals and then tell me when the last one will ever execute.  I think you're missing a '!' in the first one.

This is not the code in my SVN ... i guess the diff was made before clicking save, sorry. Should be OK now.
One more thing i have noticed though is that there are now two 'reset' commands shown when i click Tab after 'ss7 '


> On Aug. 17, 2012, 12:43 p.m., rmudgett wrote:
> > trunk/channels/sig_ss7.c, line 1638
> > <https://reviewboard.asterisk.org/r/1676/diff/12/?file=30932#file30932line1638>
> >
> >     I don't think what you are doing with res here is correct.  res is going to be nonzero only if the startcic channel has a call.  p is always pointing to another cic private channel structure here.
> >     
> >     The earlier code version for this line:
> >     } else if (p->ss7call) {
> >     made more sense.

That's how it was in the original code, before i rewrote it in v9. Without this change i was getting the GRS/REL/RSC loop too, but now i can't trigger it all. It was:
 } else if (p->ss7call && p != p_cur) { /* clear any session */
   isup_free_call(ss7, p_cur->ss7call);
   p_cur->ss7call = NULL;
 }
which is probably a mistake and you are correct it should check for 'p_cur->ss7call' instead of 'p->ss7call'


- KNK


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review6922
-----------------------------------------------------------


On Aug. 14, 2012, 8:02 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 8:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   trunk/configs/chan_dahdi.conf.sample 371240 
>   trunk/configs/ss7.timers.sample PRE-CREATION 
>   trunk/channels/sig_ss7.h 371240 
>   trunk/channels/sig_ss7.c 371240 
>   trunk/channels/chan_dahdi.c 371240 
>   trunk/configure.ac 371240 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120820/bb172190/attachment-0001.htm>