[asterisk-dev] [Code Review] Changes from Mantis ID 13495 in trunk.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review6922
-----------------------------------------------------------


Using the code from this latest version, I am still getting the GRS / REL/RSC loop.


trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1676/#comment13520>

    Where is the "reset" command word checked?



trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/1676/#comment13521>

    Cramming everything into one statement only makes the statement hard to understand and maintain.  Simplify, this by not using the ternary operator this way.  Just use if/else if logic.



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment13523>

    Put the comment before the line setting chanpos here since that is what the comment is referring to.



trunk/channels/sig_ss7.c
<https://reviewboard.asterisk.org/r/1676/#comment13522>

    I don't think what you are doing with res here is correct.  res is going to be nonzero only if the startcic channel has a call.  p is always pointing to another cic private channel structure here.
    
    The earlier code version for this line:
    } else if (p->ss7call) {
    made more sense.



trunk/configs/chan_dahdi.conf.sample
<https://reviewboard.asterisk.org/r/1676/#comment13524>

    ; has not seen proceeding
    
    Just take the chan_dahdi.conf sample from the team/rmudgett/ss7_27_knk branch.  It also documents the new slc parameter that is missing in this diff.



trunk/configs/ss7.timers.sample
<https://reviewboard.asterisk.org/r/1676/#comment13519>

    This timer does not exist in the new libss7 code so I commented it out.


- rmudgett


On Aug. 14, 2012, 8:02 a.m., KNK wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2012, 8:02 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> chan_dahdi / sig_ss7 part of changes
> 
> 
> This addresses bug SS7-27.
>     https://issues.asterisk.org/jira/browse/SS7-27
> 
> 
> Diffs
> -----
> 
>   trunk/configs/chan_dahdi.conf.sample 371240 
>   trunk/configs/ss7.timers.sample PRE-CREATION 
>   trunk/channels/sig_ss7.h 371240 
>   trunk/channels/sig_ss7.c 371240 
>   trunk/channels/chan_dahdi.c 371240 
>   trunk/configure.ac 371240 
> 
> Diff: https://reviewboard.asterisk.org/r/1676/diff
> 
> 
> Testing
> -------
> 
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
> 
> 
> Thanks,
> 
> KNK
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20120817/4982e715/attachment-0001.htm>