[asterisk-dev] [Code Review]: Clean up udptl.conf parsing

[Paul Belanger]

> On Sept. 24, 2011, 2:03 a.m., wdoekes wrote:
> > trunk/main/udptl.c, lines 1308-1312
> > <https://reviewboard.asterisk.org/r/1455/diff/1/?file=20881#file20881line1308>
> >
> >     Shouldn't nochecksums be reset to default here?

Likely, I will check.


> On Sept. 24, 2011, 2:03 a.m., wdoekes wrote:
> > trunk/main/udptl.c, line 1362
> > <https://reviewboard.asterisk.org/r/1455/diff/1/?file=20881#file20881line1362>
> >
> >     Huh? If you set it, it's >= 1 and if you don't, it uses the default which is 0?

Ya, this needs to change.  And actually use a consistent default fault.   It is possible for it to be 0, 1, and 3 (configuration file).  Depending on how the system is installed.

I'll look into it


> On Sept. 24, 2011, 2:03 a.m., wdoekes wrote:
> > trunk/main/udptl.c, line 1373
> > <https://reviewboard.asterisk.org/r/1455/diff/1/?file=20881#file20881line1373>
> >
> >     Same as udptlfecentries.

ACK'd


> On Sept. 24, 2011, 2:03 a.m., wdoekes wrote:
> > trunk/main/udptl.c, lines 1394-1401
> > <https://reviewboard.asterisk.org/r/1455/diff/1/?file=20881#file20881line1394>
> >
> >     (1) use_even_ports is checked here twice. Could be combined into a third if.
> >     
> >     (2) I find the logic rather disturbing that you can get start=end=500 if you put use_even_ports=1,start=499,end=500, but not if you do use_event_ports=0,start=500,end=500.
> >     
> >     Suggest moving the udptlstart>udptlend check to below the use_even_ports rewrite.
> >     
> >     See also ASTERISK-16250.

Okay, will checkout the JIRA issue.  Ain't configuration files fun?


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1455/#review4435
-----------------------------------------------------------


On Sept. 23, 2011, 10:57 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1455/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 10:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Another patch to help clean up Asterisk configuration file parsing.  This time it is udptl.conf
> 
> 
> Diffs
> -----
> 
>   trunk/main/udptl.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1455/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110924/4003e23b/attachment-0001.htm>