[asterisk-dev] [Code Review] rework cdr_csv parsing (2nd attempt)

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1456/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This is a follow up to a previous patch for cdr_csv.  Now that a few other modules have been updated I took a look back at this one.  We now check the ast_config_load() flags like other modules. But the major change, we will now load the module with default settings, even if a configuration files is missing.  Again, this makes the module work more like other modules.

This also include some coding guidelines fixes.


Diffs
-----

  trunk/cdr/cdr_csv.c 337894 

Diff: https://reviewboard.asterisk.org/r/1456/diff


Testing
-------

tested on local development box


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110923/c1f71d03/attachment.htm>