[asterisk-dev] [Code Review] Clean up udptl.conf parsing

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1455/#review4435
-----------------------------------------------------------



trunk/main/udptl.c
<https://reviewboard.asterisk.org/r/1455/#comment8570>

    Shouldn't nochecksums be reset to default here?



trunk/main/udptl.c
<https://reviewboard.asterisk.org/r/1455/#comment8571>

    Huh? If you set it, it's >= 1 and if you don't, it uses the default which is 0?



trunk/main/udptl.c
<https://reviewboard.asterisk.org/r/1455/#comment8572>

    Same as udptlfecentries.



trunk/main/udptl.c
<https://reviewboard.asterisk.org/r/1455/#comment8573>

    (1) use_even_ports is checked here twice. Could be combined into a third if.
    
    (2) I find the logic rather disturbing that you can get start=end=500 if you put use_even_ports=1,start=499,end=500, but not if you do use_event_ports=0,start=500,end=500.
    
    Suggest moving the udptlstart>udptlend check to below the use_even_ports rewrite.
    
    See also ASTERISK-16250.


- wdoekes


On Sept. 23, 2011, 10:57 a.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1455/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 10:57 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Another patch to help clean up Asterisk configuration file parsing.  This time it is udptl.conf
> 
> 
> Diffs
> -----
> 
>   trunk/main/udptl.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1455/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110924/9c7f0876/attachment-0001.htm>