[asterisk-dev] [Code Review]: Clean up manager.conf parsing

[Paul Belanger]

> On Sept. 24, 2011, 12:09 a.m., Tilghman Lesher wrote:
> > trunk/main/manager.c, line 6698
> > <https://reviewboard.asterisk.org/r/1461/diff/1/?file=20888#file20888line6698>
> >
> >     I really hate single letter variables when it's not just a simple counter.  Please revert this change.

Fair enough, this was done across multiple modules.  I was trying to keep things consistent.


> On Sept. 24, 2011, 12:09 a.m., Tilghman Lesher wrote:
> > trunk/main/manager.c, lines 6444-6452
> > <https://reviewboard.asterisk.org/r/1461/diff/1/?file=20888#file20888line6444>
> >
> >     So for the time that it takes to run through the configuration file, we're going to reset to defaults?  No lock, preventing usage of these variables in the meantime?  Seems like a race to me.
> >     
> >     These should probably all go into the above section, which is run only on registration and never at reload.

Regarding the lock, with out the changes I made, the same things could happen right?


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1461/#review4433
-----------------------------------------------------------


On Sept. 23, 2011, 9:11 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1461/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 9:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch helps clean up the parsing of manager.conf.  It also includes a few default settings missed on reload.
> 
> 
> Diffs
> -----
> 
>   trunk/main/manager.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1461/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110924/c0529f7b/attachment.htm>