[asterisk-dev] [Code Review] Clean up manager.conf parsing

[Tilghman Lesher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1461/#review4433
-----------------------------------------------------------



trunk/main/manager.c
<https://reviewboard.asterisk.org/r/1461/#comment8568>

    So for the time that it takes to run through the configuration file, we're going to reset to defaults?  No lock, preventing usage of these variables in the meantime?  Seems like a race to me.
    
    These should probably all go into the above section, which is run only on registration and never at reload.



trunk/main/manager.c
<https://reviewboard.asterisk.org/r/1461/#comment8567>

    I really hate single letter variables when it's not just a simple counter.  Please revert this change.


- Tilghman


On Sept. 23, 2011, 9:11 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1461/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 9:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch helps clean up the parsing of manager.conf.  It also includes a few default settings missed on reload.
> 
> 
> Diffs
> -----
> 
>   trunk/main/manager.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1461/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110924/b7874999/attachment.htm>