[asterisk-dev] [Code Review]: Clean up manager.conf parsing

[Tilghman Lesher]

> On Sept. 24, 2011, 12:09 a.m., Tilghman Lesher wrote:
> > trunk/main/manager.c, lines 6444-6452
> > <https://reviewboard.asterisk.org/r/1461/diff/1/?file=20888#file20888line6444>
> >
> >     So for the time that it takes to run through the configuration file, we're going to reset to defaults?  No lock, preventing usage of these variables in the meantime?  Seems like a race to me.
> >     
> >     These should probably all go into the above section, which is run only on registration and never at reload.
> 
> Paul Belanger wrote:
>     Regarding the lock, with out the changes I made, the same things could happen right?

Only with the two items whose values were set at the top here.  In other cases, lack of specifying an item would cause the value not to change.  That may or may not be unexpected behavior, but changing the value for a fraction of a second certainly could create possible issues.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1461/#review4433
-----------------------------------------------------------


On Sept. 23, 2011, 9:11 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1461/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2011, 9:11 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch helps clean up the parsing of manager.conf.  It also includes a few default settings missed on reload.
> 
> 
> Diffs
> -----
> 
>   trunk/main/manager.c 337894 
> 
> Diff: https://reviewboard.asterisk.org/r/1461/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110929/90fc7b48/attachment-0001.htm>