[asterisk-dev] [Code Review] [regression] Non-portable SQL added to app_voicemail

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1415/
-----------------------------------------------------------

Review request for Asterisk Developers and leifmadsen.


Summary
-------

Revision 312212 introduced a regression in app_voicemail where it breaks ODBC voicemail when the backend is MSSQL.

Line 3450 of apps/app_voicemail.c has this line:

snprintf(sql, sizeof(sql), "SELECT msgnum FROM %s WHERE dir=? order by msgnum desc limit 1", odbc_table);

The 'limit 1' is not portable to all SQL backends, and should be removed.


This addresses bug ASTERISK-18255.
    https://issues.asterisk.org/jira/browse/ASTERISK-18255


Diffs
-----

  /branches/1.8/apps/app_voicemail.c 334452 

Diff: https://reviewboard.asterisk.org/r/1415/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110906/254e8aca/attachment.htm>