[asterisk-dev] [Code Review] [regression] Non-portable SQL added to app_voicemail

[Leif Madsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1415/#review4232
-----------------------------------------------------------

Ship it!


I tested this on a customers box and it works fine now.

- Leif


On Sept. 6, 2011, 7:52 a.m., irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1415/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2011, 7:52 a.m.)
> 
> 
> Review request for Asterisk Developers and leifmadsen.
> 
> 
> Summary
> -------
> 
> Revision 312212 introduced a regression in app_voicemail where it breaks ODBC voicemail when the backend is MSSQL.
> 
> Line 3450 of apps/app_voicemail.c has this line:
> 
> snprintf(sql, sizeof(sql), "SELECT msgnum FROM %s WHERE dir=? order by msgnum desc limit 1", odbc_table);
> 
> The 'limit 1' is not portable to all SQL backends, and should be removed.
> 
> 
> This addresses bug ASTERISK-18255.
>     https://issues.asterisk.org/jira/browse/ASTERISK-18255
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/apps/app_voicemail.c 334452 
> 
> Diff: https://reviewboard.asterisk.org/r/1415/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110906/6dd59cf6/attachment.htm>