[asterisk-dev] [Code Review] chan_iax2: authdebug is now disabled by default

irroot reviewboard at asterisk.org
Tue Sep 6 01:29:03 CDT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1414/#review4230
-----------------------------------------------------------

Ship it!


There is no need for extra debug info and must say i was surprised to find this is the default and possibly should read the manuals better.


trunk/configs/iax.conf.sample
<https://reviewboard.asterisk.org/r/1414/#comment8287>

    Would it be possible to if its not included in 10 add a note here that in future versions this will be disabled. and note that it will change in the 10 CHANGES file ??


- irroot


On Sept. 5, 2011, 1:22 p.m., Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1414/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2011, 1:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Poking around in chan_iax2.c today I notices, authdebug was enabled by default, this patch disables it.
> 
> We should not have debug logic enabled by default.
> 
> 
> Diffs
> -----
> 
>   trunk/CHANGES 334292 
>   trunk/channels/chan_iax2.c 334292 
>   trunk/configs/iax.conf.sample 334292 
> 
> Diff: https://reviewboard.asterisk.org/r/1414/diff
> 
> 
> Testing
> -------
> 
> local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110906/53eeb028/attachment.htm>


More information about the asterisk-dev mailing list